docs: dispatch testing note (delegation to package:asobi)#12
Merged
Conversation
flame_asobi delegates all WebSocket protocol dispatch to package:asobi. Point readers at asobi-dart's dispatch_test.dart for protocol coverage and clarify that this package's tests target Flame component integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package:asobiand maintains no event-name → callback mapping of its ownonMatchState,onWorldTick,onMatchmakerMatched, vote streams, etc.) and translate them into Flame components## Dispatch testingsection to the README pointing at asobi-dart'stest/dispatch_test.dartso SDK consumers know where protocol coverage livesInvestigation findings
Per the per-SDK protocol dispatch test rollout, I read all of
lib/:flame_asobi.dartpackage:asobi+ the mixinshas_asobi.dartAsobiClient, no routingasobi_matchmaker.dartonConnected/onMatchmakerMatched/onErrorstreamsasobi_network_sync.dartonMatchState/onMatchFinishedstreams; translatesMatchState→ Flame componentsasobi_world_sync.dartonWorldTickstream; switches onEntityDelta.op(a/u/r) — entity delta op codes inside an already-dispatched payload, not protocol routingasobi_input_sender.dartmatch.input, no routingasobi_vote_listener.dartasobi_player.dart/asobi_projectile.dartPlayerState/ProjectileStateto position componentsNo event-name → callback maps. No re-firing of server messages as different events. Pure delegation, so no flame-specific dispatch test is warranted.
Test plan
lib/reviewed; no protocol dispatch table foundflame_asobi#11left untouched per task constraints